Add a test case where fetchGit is failing to cache due to packed-refs #13456
+88
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
builtins.fetchGit is not using the cached Git directory if packed-references are used. This is because the ref file for the fetchGit `refs/heads/master` is used to check the mtime for whether to cache or not. Let's at least codify this failure in a test case.
github-actions
bot
added
the
with-tests
This was referenced Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builtins.fetchGit is not using the cached Git directory if packed-references are used.
This is because the ref file for the fetchGit
refs/heads/masteris used to check the mtime for whether to cache or not.Let's at least codify this failure in a test case.
For now the test case expects failure but we should change it once the issue is resolved.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.