Hidden directories are just ignore

[g14wx]

Bug Description

The hidden directories like .github are not created in the server.

My Action Config

on: push
name: 🚀 Deploy website on push
jobs:
  web-deploy:
    name: 🎉 Deploy
    runs-on: ubuntu-latest
    steps:
    - name: 🚚 Get latest code
      uses: actions/checkout@v2.3.2

    - name: Composer install dependencies
      uses: php-actions/composer@v5
      with:
        php_version: 7.3
        command: update 
    
    - name: 📂 Sync files
      uses: SamKirkland/FTP-Deploy-Action@4.0.0
      with:
        server: ${{ secrets.ftp_server }}
        username: ${{ secrets.ftp_username }}
        password: ${{ secrets.ftp_password }}

My Action Log

uploading "vendor/myclabs/deep-copy/.github/FUNDING.yml"
Error 553 FileNameNotAllowed, you don't have access to upload that file
FTPError: 553 Can't open that file: No such file or directory
    at FTPContext._onControlSocketData (/home/runner/work/_actions/SamKirkland/FTP-Deploy-Action/4.0.0/dist/index.js:3759:39)
    at Socket.<anonymous> (/home/runner/work/_actions/SamKirkland/FTP-Deploy-Action/4.0.0/dist/index.js:3600:44)
    at Socket.emit (events.js:210:5)
    at addChunk (_stream_readable.js:309:12)
    at readableAddChunk (_stream_readable.js:286:13)
    at Socket.Readable.push (_stream_readable.js:224:10)
    at TCP.onStreamRead (internal/stream_base_commons.js:182:23) {
  name: 'FTPError',
  code: 553
}
FTPError: 553 Can't open that file: No such file or directory
    at FTPContext._onControlSocketData (/home/runner/work/_actions/SamKirkland/FTP-Deploy-Action/4.0.0/dist/index.js:3759:39)
    at Socket.<anonymous> (/home/runner/work/_actions/SamKirkland/FTP-Deploy-Action/4.0.0/dist/index.js:3600:44)
    at Socket.emit (events.js:210:5)
    at addChunk (_stream_readable.js:309:12)
    at readableAddChunk (_stream_readable.js:286:13)
    at Socket.Readable.push (_stream_readable.js:224:10)
    at TCP.onStreamRead (internal/stream_base_commons.js:182:23) {
  name: 'FTPError',
  code: 553
}

[abakucz]

Exactly my problem. Even exactly with same package - myclabs/deep-copy.

I suspect the problem lies with default exclude option here.

This specific package has only one file in its .github directory i.e. vendor/myclabs/deep-copy/.github/FUNDING.yml. Which matches default exclude option [.git*, .git*/**], so the vendor/myclabs/deep-copy/.github/ directory is not created. That's a correct behaviour I'd say.

But then it for some reason tries to copy FUNDING.yml file to a directory which doesn't exists and which causes the problem.

Workaround

Add **/.git*/** rule to exclude option.

E.g.

exclude: .git*
   - .git*/**
   -  **/.git*/**

[g14wx]

Exactly my problem. Even exactly with same package - myclabs/deep-copy.

I suspect the problem lies with default exclude option here.

This specific package has only one file in its .github directory i.e. vendor/myclabs/deep-copy/.github/FUNDING.yml. Which matches default exclude option [.git*, .git*/**], so the vendor/myclabs/deep-copy/.github/ directory is not created. That's a correct behaviour I'd say.

But then it for some reason tries to copy FUNDING.yml file to a directory which doesn't exists and which causes the problem.

Workaround

Add **/.git*/** rule to exclude option.

E.g.

exclude: .git*

   - .git*/**

   -  **/.git*/**

I will try out.