Pick up changes from .rubocop-todo.yml #3625
Conversation
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
|
I have signed the CLA! |
test/server_test.rb
Outdated
There was a problem hiding this comment.
The tests here a bit mixed. Some of these are validating other logic using the RuboCop configuration file, but it's not directly related.
Can we please simply make another version of test_rubocop_config_changes_trigger_workspace_diagnostic_refresh that uses the RuboCop todo file instead of .rubocop.yml? That should be enough. And then feel free to extract a common method to test the two of them.
AlexVPopov
force-pushed
the
pick-up-rubocop-todo
branch
from
7131bca to
53df420
Compare
| ".rubocop.yml", | ||
| ".rubocop", | ||
| ".rubocop_todo.yml", | ||
| ] #: Array[String] |
There was a problem hiding this comment.
Let's freeze it because then Sorbet will automatically know that this is a 3 element Tuple of strings instead of an array of arbitrary size.
| ] #: Array[String] | |
| ].freeze |
| }) | ||
|
|
||
| @server.global_state.index.index_all(uris: []) | ||
| assert_rubocop_config_triggers_diagnostic_refresh_without_setup(config_file) |
There was a problem hiding this comment.
| assert_rubocop_config_triggers_diagnostic_refresh_without_setup(config_file) | |
| assert_rubocop_config_triggers_diagnostic_refresh_without_setup(uri) |
| def assert_rubocop_config_triggers_diagnostic_refresh_without_setup(config_file) | ||
| uri = URI::Generic.from_path(path: File.join(Dir.pwd, config_file)) | ||
|
|
There was a problem hiding this comment.
| def assert_rubocop_config_triggers_diagnostic_refresh_without_setup(config_file) | |
| uri = URI::Generic.from_path(path: File.join(Dir.pwd, config_file)) | |
| def assert_rubocop_config_triggers_diagnostic_refresh_without_setup(uri) |
vinistock
added
bugfix
Motivation
Closes #3609
Pick up changes in
.rubocop_todo.yml.Implementation
As suggested by @vinistock, adjust the patterns for rubocop config files.
Automated Tests
I'm not sure all the tests I've added are relevant, I'm open to changing them with some feedback and guidance.
Manual Tests
I couldn't make Cursor use my local version of
.ruby-lsp😬, I'd be happy to get information about how I can test this.