Skip to content

Updated AWSSDK.S3 to 4.0 #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mdupras
Copy link
Contributor

@mdupras mdupras commented Jun 4, 2025

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Updated the AWSSDK.S3 to 4.0 release and fix the compilation issue.
Now metadata.LastModified can be null, I don't think it's like to happen in this scenario, but if it does the default Date is Now to assume the Image needs to be refreshed.

@dlemstra
Copy link
Member

dlemstra commented Jun 4, 2025

The 3.x range is also still being updated but I think we can upgrade to the 4.x range because we don't need net3.5 support

@JimBobSquarePants
Copy link
Member

@dlemstra I'm not convinced we can update yet.

By doing so we introduce a breaking change via the dependency. Normally that would require a major version on our part.

@mdupras we have multiple failing tests here. Could you please have a look?

@@ -9,6 +9,8 @@ namespace SixLabors.ImageSharp.Web;

internal static class AmazonS3ClientFactory
{
static AmazonS3ClientFactory() => AWSConfigs.InitializeCollections = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Altering global behavior for transitive dependency does not appear be a prudent. It would be more appropriate to update the code to accommodate changes in behavior.

@mdupras
Copy link
Contributor Author

mdupras commented Jun 11, 2025

@dlemstra I'm not convinced we can update yet.

By doing so we introduce a breaking change via the dependency. Normally that would require a major version on our part.

@mdupras we have multiple failing tests here. Could you please have a look?

Thanks, I'm looking into it a bit. Managed to get the test failing locally, I'll try to take some time to investigate that soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants