Skip to content

Add implicit resharper settings #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stefannikolei
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

@Copilot Copilot AI review requested due to automatic review settings June 28, 2025 18:49
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds ReSharper-specific settings to enforce implicit object creation style alongside existing Roslyn rules.

  • Introduces a ReSharper inspection severities comment block.
  • Adds two Resharper settings to error on object creation when type is (not) evident.
Comments suppressed due to low confidence (3)

.editorconfig:164

  • Consider adding a reference or URL to the official ReSharper EditorConfig documentation here so that future contributors can verify valid setting names and expected values.
# ReSharper inspection severities

.editorconfig:165

  • Double-check that the inspection key resharper_arrange_object_creation_when_type_evident_highlighting matches the official ReSharper naming convention for implicit object creation inspections. If the plugin uses a different identifier (for example including “implicit” or a different suffix), update it to the correct property name.
resharper_arrange_object_creation_when_type_evident_highlighting = error

.editorconfig:166

  • Similarly, verify that the key resharper_arrange_object_creation_when_type_not_evident_highlighting is correctly named according to ReSharper’s EditorConfig support. Adjust it if the official inspection ID differs.
resharper_arrange_object_creation_when_type_not_evident_highlighting = error

Copy link

codecov bot commented Jun 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19%. Comparing base (6fe431a) to head (c92d6fa).
Report is 4 commits behind head on main.

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #52   +/-   ##
==================================
  Coverage    19%   19%           
==================================
  Files         4     4           
  Lines       346   346           
  Branches     85    85           
==================================
  Hits         68    68           
  Misses      278   278           
Flag Coverage Δ
unittests 19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JimBobSquarePants JimBobSquarePants merged commit 132a823 into SixLabors:main Jun 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants