chore: add typescript-eslint/require-await rule #9029

minseong0324 · 2025-04-15T19:02:18Z

nx-cloud · 2025-04-15T19:02:40Z

View your CI Pipeline Execution ↗ for commit e548b0b.

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	45s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2025-06-28 15:52:59 UTC

pkg-pr-new · 2025-04-15T19:05:48Z

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9029

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9029

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9029

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9029

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9029

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9029

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9029

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9029

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9029

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9029

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9029

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9029

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9029

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9029

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9029

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9029

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9029

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9029

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9029

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9029

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9029

commit: e548b0b

eslint.config.js

codecov · 2025-06-28T15:53:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (7dafa93) to head (e548b0b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #9029       +/-   ##
==========================================
- Coverage   45.37%   0.00%   -45.38%     
==========================================
  Files         207      49      -158     
  Lines        8277    2204     -6073     
  Branches     1868     181     -1687     
==========================================
- Hits         3756       0     -3756     
+ Misses       4080    2083     -1997     
+ Partials      441     121      -320

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`∅ <ø> (∅)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`∅ <ø> (∅)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`0.00% <ø> (ø)`
@tanstack/query-core	`∅ <ø> (∅)`
@tanstack/query-devtools	`∅ <ø> (∅)`
@tanstack/query-persist-client-core	`∅ <ø> (∅)`
@tanstack/query-sync-storage-persister	`∅ <ø> (∅)`
@tanstack/query-test-utils	`∅ <ø> (∅)`
@tanstack/react-query	`∅ <ø> (∅)`
@tanstack/react-query-devtools	`∅ <ø> (∅)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`∅ <ø> (∅)`
@tanstack/solid-query	`∅ <ø> (∅)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`∅ <ø> (∅)`
@tanstack/svelte-query	`∅ <ø> (∅)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`∅ <ø> (∅)`
@tanstack/vue-query	`∅ <ø> (∅)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

manudeli

It's time to add this rule finally

chore: add typescript-eslint/require-await rule

4d7cd20

TkDodo reviewed Apr 17, 2025

View reviewed changes

eslint.config.js Outdated Show resolved Hide resolved

TkDodo and others added 4 commits April 17, 2025 11:17

Merge branch 'main' into chore/ts-async-lint-rules

8d1b2d8

Merge branch 'main' into chore/ts-async-lint-rules

5e47f22

reflect feedback

9dd5dec

Merge branch 'main' into chore/ts-async-lint-rules

9ad919a

github-actions bot added package: query-persist-client-core package: query-devtools package: angular-query-experimental package: query-codemods labels Apr 18, 2025

minseong0324 marked this pull request as draft April 18, 2025 15:44

minseong0324 force-pushed the chore/ts-async-lint-rules branch 3 times, most recently from a923146 to 390a5cb Compare April 18, 2025 16:16

github-actions bot removed the package: query-codemods label Apr 18, 2025

minseong0324 force-pushed the chore/ts-async-lint-rules branch from 390a5cb to 9ad919a Compare April 18, 2025 16:25

github-actions bot removed package: query-persist-client-core package: query-devtools package: angular-query-experimental labels Apr 18, 2025

minseong0324 marked this pull request as ready for review April 18, 2025 16:26

Merge branch 'main' into chore/ts-async-lint-rules

cf0cb22

TkDodo reviewed Apr 19, 2025

View reviewed changes

eslint.config.js Outdated Show resolved Hide resolved

TkDodo and others added 6 commits April 19, 2025 20:26

Update eslint.config.js

9efe120

Merge branch 'main' into chore/ts-async-lint-rules

4e8332f

Merge branch 'main' into chore/ts-async-lint-rules

003754d

Merge branch 'main' into chore/ts-async-lint-rules

c80f93d

Merge branch 'main' into chore/ts-async-lint-rules

904bb53

Merge branch 'main' into chore/ts-async-lint-rules

31982b9

github-actions bot added package: vue-query package: solid-query package: query-persist-client-core package: svelte-query package: query-async-storage-persister package: query-sync-storage-persister package: solid-query-persist-client package: svelte-query-persist-client labels May 7, 2025

minseong0324 force-pushed the chore/ts-async-lint-rules branch from b2e5313 to 0013aaa Compare May 7, 2025 23:58

minseong0324 added 2 commits May 8, 2025 08:58

Merge branch 'main' into chore/ts-async-lint-rules

bdb6bb2

chore(query-codemods): remove typescript-eslint/require-await off rule

f966b60

github-actions bot removed package: react-query package: query-core package: angular-query-experimental package: query-broadcast-client-experimental labels May 8, 2025

minseong0324 and others added 3 commits May 9, 2025 22:55

Merge branch 'main' into chore/ts-async-lint-rules

f5da04c

Merge branch 'main' into chore/ts-async-lint-rules

18915aa

Merge branch 'main' into chore/ts-async-lint-rules

e548b0b

manudeli approved these changes Jun 28, 2025

View reviewed changes

manudeli merged commit f4a1115 into TanStack:main Jun 28, 2025
6 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore: add typescript-eslint/require-await rule #9029

chore: add typescript-eslint/require-await rule #9029

minseong0324 commented Apr 15, 2025

Uh oh!

nx-cloud bot commented Apr 15, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Apr 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jun 28, 2025 •

edited

Loading

Uh oh!

manudeli left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chore: add typescript-eslint/require-await rule #9029

chore: add typescript-eslint/require-await rule #9029

Conversation

minseong0324 commented Apr 15, 2025

Uh oh!

nx-cloud bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

manudeli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nx-cloud bot commented Apr 15, 2025 •

edited

Loading

pkg-pr-new bot commented Apr 15, 2025 •

edited

Loading

codecov bot commented Jun 28, 2025 •

edited

Loading