Remove windows-2019 from workflows as the image deprecation has begun on 2025-06-01 #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Removes deprecated Windows 2019 runner images and replaces them with Windows 2022 across the Python package build workflow.
- Update default
inputs.platformsto usewindows-2022instead ofwindows-2019 - Update the PowerShell matrix generation to reflect the new
windows-2022labels
Comments suppressed due to low confidence (1)
.github/workflows/build-python-packages.yml:47
- The default matrix string uses
macos-13without an architecture suffix, whereas the inputs default listsmacos-13_x64. Align these names to prevent confusion and ensure they match runner labels.
[String[]]$configurations = "${{ inputs.platforms || 'ubuntu-22.04,ubuntu-22.04_arm64,ubuntu-24.04,ubuntu-24.04_arm64,macos-13,macos-14_arm64,windows-2022_x64,windows-2022_x86,windows-11_arm64' }}".Split(",").Trim()
| @@ -20,7 +20,7 @@ on: | |||
| PLATFORMS: | |||
| description: 'Platforms for execution in "os" or "os_arch" format (arch is "x64" by default)' | |||
| required: true | |||
| default: 'ubuntu-22.04,ubuntu-22.04_arm64,ubuntu-24.04,ubuntu-24.04_arm64,macos-13_x64,macos-14_arm64,windows-2019_x64,windows-2019_x86,windows-11_arm64' | |||
| default: 'ubuntu-22.04,ubuntu-22.04_arm64,ubuntu-24.04,ubuntu-24.04_arm64,macos-13_x64,macos-14_arm64,windows-2022_x64,windows-2022_x86,windows-11_arm64' | |||
There was a problem hiding this comment.
The platforms list is duplicated between the workflow inputs and the PowerShell matrix script. Consider extracting this list into a single YAML anchor or environment variable to ensure consistency and reduce the chance of drift.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the windows-2019 from workflows, as it the deprication started on 2026-06-01 and will be fully unsupported by 2025-06-30 as per actions/runner-images#12045.