Addressed all buildifier warnings #359
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
requested review from
cloudhan,
jsharpe and
ryanleary
as code owners
UebelAndre
changed the title
|
please disable all those stylistic linting and revert all those style change. |
|
If you can be specific about the warnings I can remove them but if this is still a controversial change I can close it out. |
|
Is it possible to make it opt-in first then we gradually enable more of them? |
hofbi
reviewed
Jun 30, 2025
Comment on lines
+117
to
+130
|
|
||
| buildifier: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Download Buildifier | ||
| run: | | ||
| wget "https://github.com/bazelbuild/buildtools/releases/download/v${BUILDIFIER_VERSION}/buildifier-linux-amd64" -O buildifier | ||
| chmod +x ./buildifier | ||
| env: | ||
| BUILDIFIER_VERSION: 8.0.3 | ||
| - name: Buildifier | ||
| run: | | ||
| ./buildifier -lint=warn -mode=check -r ${{ github.workspace }} |
There was a problem hiding this comment.
Since this project already uses pre-commit, I would suggest to add buildifier there. This way, users can easily run it locally and it gets executed in CI automatically. For this, simply add
- repo: https://github.com/Warchant/pre-commit-buildifier
rev: 0.1.5
hooks:
- id: buildifier
args: [--version, "v8.2.0"]
- id: buildifier-lint
args: [--version, "v8.2.0"]to the pre-commit-config.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change applies buildifier auto-fixes for all available fixes and then in a second commit manually updates implementations to conform to the warning.
Additionally
.buildifier.jsonhas been added with the outputs ofbuildifier -config=example. Maintainers should remove anything there that offend them.closes #358