Skip to content

Add structs.merge #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add structs.merge #578

wants to merge 3 commits into from

Conversation

mattyclarkson
Copy link 

one = struct(a = 1)
two = struct(b = 2)
overwrite = struct(a = 3)
merged = structs.merge(one, two , overwrite)
# struct(a = 3, b = 2)

fmeum
fmeum reviewed Jun 13, 2025
View reviewed changes
@mattyclarkson mattyclarkson force-pushed the structs.merge branch 4 times, most recently from 2ab03ac to 5b52c11 Compare June 19, 2025 10:47
@mattyclarkson
Copy link
Author

I am unclear why this is failing the buildifier job in the CI.

buildifier (same version as CI) is clean for me locally on lib/structs.bzl, tests/structs_test.bzl, MODULE.bazel and WORKSPACE which have been modified.

Maybe an infra-failure?

fmeum
fmeum reviewed Jun 20, 2025
View reviewed changes
@mattyclarkson
Add structs.merge
c1b184a
@mattyclarkson
Update structs.to_dict test function name
67d6422 
Copy/paste error.
@mattyclarkson
Check struct.{to_json,to_proto} are built-in functions
7e4dd74 
`to_json`/`to_proto` function have been removed from `structs`.

Check that they are built-in functions before eliminating the keys.

Tests are gated behind `bazel_features.rules.no_struct_field_denylist` to prevent breakage on old Bazel when running the tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum fmeum left review comments

@brandjon brandjon Awaiting requested review from brandjon brandjon is a code owner

@tetromino tetromino Awaiting requested review from tetromino tetromino is a code owner

@comius comius Awaiting requested review from comius comius is a code owner

@hvadehra hvadehra Awaiting requested review from hvadehra hvadehra is a code owner

@c-mita c-mita Awaiting requested review from c-mita c-mita is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattyclarkson @fmeum