Add Alma 9 rpmbuild + bazel environment for examples #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a consistent starting point for running rpmbuild examples using a docker container build on Alma 9. Closes: bazelbuild#968
aiuto
reviewed
Jul 8, 2025
sounds great, thanks |
tonyaiuto
requested changes
Jul 10, 2025
This is required for better compatibility with host platforms where the active uid (from id -u) might conflict with the base image system user ids. We chose 1000 as something outside the standard uid range, and conveniently the default uid on Ubuntu systems, ref: https://refspecs.linuxfoundation.org/LSB_3.0.0/LSB-Core-generic/LSB-Core-generic/uidrange.html I've also changed the Dockerfile to pick up the TARGETARCH value so that we get the right bazelisk executable.
tonyaiuto
reviewed
Jul 11, 2025
Since it runs `exec docker ...` as the last step, putting it inside a subhsell is not so useful.
tonyaiuto
approved these changes
Jul 11, 2025
|
Thanks for doing this. It's going to be a huge help for validating rpmbuild PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a consistent starting point for running rpmbuild examples using a docker container build on Alma 9.
Closes: #968