Skip to content

release-23.2: kvcoord: add logging in TestWaiterOnRejectedCommit #148944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

release-23.2: kvcoord: add logging in TestWaiterOnRejectedCommit #148944

merged 1 commit into from
Jun 27, 2025
+6 −2

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 26, 2025 •
edited by pav-kv
Loading

Backport 1/1 commits from #148917 on behalf of @pav-kv.

This should help debugging/deflaking this test should it fail again. The conjecture is that we end up with more than one command ID, and only one gets the injected error, while another one succeeds.

Informs #148910

Release justification: test-only logging

@pav-kv
kvcoord: add logging in TestWaiterOnRejectedCommit
43f5302 
This should help debugging/deflaking this test should it fail again. The
conjecture is that we end up with more than one command ID, and only one
gets the injected error, while another one succeeds.

Epic: none
Release note: none
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-148917 branch from 0e2ac16 to 43f5302 Compare June 26, 2025 19:54
@blathers-crl blathers-crl bot requested a review from a team as a code owner June 26, 2025 19:54
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 26, 2025
@blathers-crl blathers-crl bot requested review from iskettaneh and tbg June 26, 2025 19:54
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Jun 26, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jun 26, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@pav-kv pav-kv merged commit e44b1f3 into release-23.2 Jun 27, 2025
5 checks passed
@pav-kv pav-kv deleted the blathers/backport-release-23.2-148917 branch June 27, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pav-kv pav-kv pav-kv approved these changes

@iskettaneh iskettaneh Awaiting requested review from iskettaneh

@tbg tbg Awaiting requested review from tbg

Assignees

@pav-kv pav-kv

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. target-release-23.2.28
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cockroach-teamcity @pav-kv