-
Notifications
You must be signed in to change notification settings - Fork 3.9k
release-25.1: kvcoord: add logging in TestWaiterOnRejectedCommit #148950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dcf0803
to
c0296e3
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
This should help debugging/deflaking this test should it fail again. The conjecture is that we end up with more than one command ID, and only one gets the injected error, while another one succeeds. Epic: none Release note: none
c0296e3
to
9ef6ba3
Compare
✅ PR #148950 is compliant with backport policy Confidence: high 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Backport 1/1 commits from #148917 on behalf of @pav-kv.
This should help debugging/deflaking this test should it fail again. The conjecture is that we end up with more than one command ID, and only one gets the injected error, while another one succeeds.
Informs #148910
Release justification: test-only logging