move to Verify #2616
Open
move to Verify #2616
+44
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(DisableArcade)' == '1'"> | ||
| <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.14.1" /> | ||
| <!-- The xunit version should be kept in sync with the one that Arcade promotes --> |
There was a problem hiding this comment.
Does Arcade promote xunit 2.9.3 now or in the near future?
|
It looks like the files documenting the API surface would no longer be part of the version controlled artifacts in the repo? These are useful to have and a key reason why ApprovalTests was used here. Does Verify have an analogous approach? |
|
@jonsequitur my mistake. that should now be fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.