server_family: Expose command latency stats as part of info #5372
+83
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijat
force-pushed
the
abhijat/feat/5092/support-latency-percentiles
branch
5 times, most recently
from
3c0963e to
a908568
Compare
Signed-off-by: Abhijat Malviya <abhijat@dragonflydb.io>
abhijat
force-pushed
the
abhijat/feat/5092/support-latency-percentiles
branch
from
a908568 to
f513541
Compare
Signed-off-by: Abhijat Malviya <abhijat@dragonflydb.io>
abhijat
force-pushed
the
abhijat/feat/5092/support-latency-percentiles
branch
from
f513541 to
9a7ed14
Compare
|
In this PR, the latency stats for sub-commands (for example This is because we do not have tracking information at the command registry level for sub-commands. It might be useful to return the latency for individual sub-commands eventually. |
Signed-off-by: Abhijat Malviya <abhijat@dragonflydb.io>
abhijat
force-pushed
the
abhijat/feat/5092/support-latency-percentiles
branch
from
9a7ed14 to
aacb5d5
Compare
abhijat
changed the title
|
I will review this in the morning. Witting here so I don't forget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command latency is recorded in its histogram when command is invoked.
When
info latencystatsis run, the latency for a fixed set of percentiles (50,99,99.9 by default) is returned per command.Currently the percentiles are fixed, but in a later PR these should be made configurable as command line option as well as
config set.FIXES #5092