-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Update 'endpoint health' command to avoid calling flags.SetPflagsFromEnv
multiple times
#20120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…Env multiple times Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
cc @fuweid @ivanvc @jmhbnz @serathius Let's get the fix included in v3.6.1 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 24 files with indirect coverage changes @@ Coverage Diff @@
## main #20120 +/- ##
==========================================
- Coverage 69.27% 69.23% -0.04%
==========================================
Files 413 413
Lines 34354 34364 +10
==========================================
- Hits 23799 23793 -6
- Misses 9156 9175 +19
+ Partials 1399 1396 -3 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-3.6 |
@ahrtr: new pull request created: #20121 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fix #20118
Note both
etcdctl endpoint health
andetcdctl endpoint health --cluster
have this issue.flags.SetPflagsFromEnv
should only be called once. It has already been called inclientConfigFromCmd
, so there is no need to call it again inepHealthCommandFunc
.Also reverted #18742 to fix the
etcdctl endpoint health --cluster
issuePlease read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.