-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Split model Step function #20195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split model Step function #20195
Conversation
9af1cf5
to
36abc9e
Compare
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
36abc9e
to
87a2ed3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #20195 +/- ##
==========================================
- Coverage 69.31% 69.29% -0.03%
==========================================
Files 413 413
Lines 34367 34367
==========================================
- Hits 23821 23813 -8
- Misses 9148 9166 +18
+ Partials 1398 1388 -10 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The refactoring makes sense and makes the code cleaner.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fuweid, nwnt, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @joshjms @nwnt @fuweid @siyuanfoundation