-
Notifications
You must be signed in to change notification settings - Fork 142
Dev-docs: Add HTTP Tracer explanation doc #1782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Prateek Singh <prateeksingh9741@gmail.com>
hey @prateek041, is this still a draft? do you want keep adding stuff or we can review it? |
Hey @marctc so I raised this MR a while back because I was assessing if the project wanted documentation like this on the project. Specifically in the DevDocs sections. If the project has a need for it, there is tons of more content I can write. |
Hey @prateek041, that sounds amazing. We would like to have such documentation like this. Feel free to put as ready for review and we can take a look. |
The HTTP tracer has been removed - the job is now done in https://github.com/open-telemetry/opentelemetry-ebpf-instrumentation/blob/main/bpf/tpinjector/tpinjector.c |
@rafaelroquetto thanks for pointing that out, but the idea behind, I.e. attaching the trace-parent header is still looks the same. |
@prateek041 indeed - however, it may be worth updating the documentation to reflect the current approach which relies on This class of programs no longer requires us to manually compute the TCP checksum or deal with the sequence numbers, as they operate at a higher level. We still have a TC egress program for injecting the traceparent on the IP header in case the above fails (e.g. SSL), and another one on ingress to extract the options from the IP header - the code is here: https://github.com/open-telemetry/opentelemetry-ebpf-instrumentation/blob/main/bpf/tctracer/tctracer.c |
Thanks for the detailed response @rafaelroquetto I will definitely update this over the weekend. |
No description provided.