Fix #36897: Resolve NO_PROXY recognition issue in oss remote backend #36898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Changelog WarningCurrently this PR would target a v1.13 release. Please add a changelog entry for in the .changes/v1.13 folder, or discuss which release you'd like to target with your reviewer. If you believe this change does not need a changelog entry, please add the 'no-changelog-needed' label. |
|
@xiaozhu36 per codeowners |
|
@xiaozhu36 Friendly reminder to please review this backend PR. If we want to include this in the 1.13 release, it needs to be approved and merged within the next couple of weeks. |
|
@xiehan I have reviewed the PR and there is no problem. |
|
Great! @xingjiu Could you rebase your PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36897
This PR addresses [Terraform Issue #36897]. The core implementation was previously contributed to OpenTofu PR #2675 and is adapted here to fit Terraform's codebase.
Target Release
1.13.x
CHANGELOG entry