Add actions to provider interface #37006
Conversation
DanielMSchmidt
added
the
no-changelog-needed
|
Will the version of the protocol version stay at 6.10? |
DanielMSchmidt
force-pushed
the
TF-25930
branch
3 times, most recently
from
f3d5ac9 to
0b0cfdd
Compare
| } | ||
| } | ||
|
|
||
|
|
| @@ -875,3 +932,80 @@ message ConfigureStateStore { | |||
| repeated Diagnostic diagnostics = 1; | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| } | ||
| } | ||
|
|
||
|
|
| linkedResouceSchemas := actionSchema.LinkedResources() | ||
| inputLinkedResources := make([]providers.LinkedResourcePlanData, 0, len(req.LinkedResources)) | ||
|
|
||
| for i, lr := range req.LinkedResources { |
There was a problem hiding this comment.
Can you add some comments (here or in top-level method comments) that explain why we aren't sending the planned_state to the provider, when we do for the protocol v5 version? I remember seeing you and James chat about it and I think it would help if that was captured somewhere here
|
|
||
| priorState, err := decodeDynamicValue6(lr.PriorState, linkedResourceTy) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to decode prior state for linked resource #%d (%q) in action %q: %w", i+1, linkedResouceSchemas[i].TypeName, req.ActionType, err) |
There was a problem hiding this comment.
Is i+1 the correct thing to show the user here? I thought terraform generally always used [0] for the first item in a list and it seems like it'd be odd if we switched that just for actions (I could also be wrong about that given this context!)
| return resp | ||
| } | ||
|
|
||
| func (p *GRPCProvider) InvokeAction(r providers.InvokeActionRequest) (resp providers.InvokeActionResponse) { |
There was a problem hiding this comment.
This one is just a genuine question I'm curious about, not a review:
How will the action event stream get cancelled from the terraform side (ie user ctrl-c or a timeout)? Does that get handled by the provider when tf calls Stop()?
| // Copyright (c) HashiCorp, Inc. | ||
| // SPDX-License-Identifier: BUSL-1.1 | ||
|
|
||
| package mock_tfplugin5 |
There was a problem hiding this comment.
mock.go is generated, is there a reason these methods can't also be generated?
This PR adds actions to the provider interface and implements the basic functionality against the provider protocol.
Fixes #
Target Release
1.13.x
CHANGELOG entry