Add ability to create a hash of the state_store block #37278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h of a state_store block
…ude the provider block
SarahFrench
added
the
no-changelog-needed
…blocks, and validate incoming schema and config
SarahFrench
commented
Jun 27, 2025
Comment on lines
+115
to
+130
| // The value `b.Config` will include data about the provider block nested inside state_store | ||
| // so we need to ignore it. PartialDecode allows that 'extra' provider block to be ignored, | ||
| // but we need to check that's the only thing being ignored. | ||
| val, decodeDiags := hcldec.Decode(b.Config, spec, nil) | ||
| if decodeDiags.HasErrors() { | ||
| for _, diag := range decodeDiags { | ||
| if diag.Detail == "Blocks of type \"provider\" are not expected here." { | ||
| // We want to tolerate this. | ||
| continue | ||
| } | ||
| diags = diags.Append(diag) | ||
| } | ||
| if diags.HasErrors() { | ||
| return 0, diags | ||
| } | ||
| } |
There was a problem hiding this comment.
@radeksimko an alternative to this could be to update the decodeStateStoreBlock logic to split out the provider and state_store config, instead of combining it all inside the single Config field. Maybe instead there could be a StateStoreConfig, ProviderConfig, and rawConfig field in that struct so that the separate config can be accessed, but there's also a record of the original value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Hash method, similar to the existing (*Backend) Hash method.
This method should be able to tolerate the nested provider block, assuming that the schema is correct. The new test added here attempts to assert that.
Target Release
1.13.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry