Skip to content

Add gottwald to admin and maintainers for capdo #5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add gottwald to admin and maintainers for capdo #5682

wants to merge 1 commit into from
+2 −0

Conversation

gottwald
Copy link

I'm maintainer of CAPDO and also working for DO.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Jun 26, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 26, 2025
@gottwald gottwald force-pushed the ig/capdo-admin-addition branch from 4537089 to 978561a Compare June 26, 2025 12:45
@gottwald gottwald changed the title Add @gottwald to admin and maintainers for capdo Add gottwald to admin and maintainers for capdo Jun 26, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 26, 2025
@gottwald
Add gottwald to admin and maintainers for capdo
d2b7fcb 
I'm maintainer of CAPDO and also working for DO.
@gottwald gottwald force-pushed the ig/capdo-admin-addition branch from 978561a to d2b7fcb Compare June 26, 2025 12:48
@gottwald
Copy link
Author

/assign @timoreimann @cpanato

@cpanato
Copy link
Member

cpanato commented Jun 26, 2025

The K8s process is to have some meaningful review and contributions to the project before getting maintainer status

@cpanato
Copy link
Member

cpanato commented Jun 26, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2025
@gottwald
Copy link
Author

@cpanato wasn't that already verified when I got added to the maintainers group in the owners file?
https://github.com/kubernetes-sigs/cluster-api-provider-digitalocean/blob/a61495b8665c2d26e54bc4de80d5bb3ace0c183d/OWNERS_ALIASES#L23

@cpanato
Copy link
Member

cpanato commented Jun 26, 2025

i am sorry! you right

Looking at the list, we need to do some cleaning. I will open a pr

@cpanato
Copy link
Member

cpanato commented Jun 28, 2025

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cpanato, gottwald
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@timoreimann timoreimann

@cpanato cpanato

Labels
area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gottwald @cpanato @k8s-ci-robot @timoreimann