Skip to content

fix: ensure correct color scheme is applied in applyTheme function #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SantosVilanculos
Copy link

This sets the color-scheme CSS property, informing the browser of the page's preferred color scheme. This allows the user agent to apply consistent styling to its default UI elements (e.g., form controls, scrollbars), enhancing theme integration and user experience.

@OliverSpeak
Copy link

Might be cleaner to just add color-scheme: dark; directly in the .dark class in app.css instead. Should still work with the use-appearance hook.

@SantosVilanculos
Copy link
Author

When that way because of specificity and inheritance, even https://ui.shadcn.com/ does it that way. It uses the style attribute.

20250626192557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants