[UnitTests] Add initial set of dedicated early-exit unit tests. #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds initial unit tests for early-exit vectorization covering a variation of auto-vectorization and forced interleaving with pragmas. The interleaving variant is currently mis-compiled and needs * llvm/llvm-project#145340 * llvm/llvm-project#145394. We should probably extend the tests to make sure we cover various other scenarios, including returning the loaded element for the early exit, different index types and array sizes.
fhahn
force-pushed
the
test-suite-early-exit-vec
branch
from
b349e09 to
28ae6ea
Compare
david-arm
reviewed
Jun 26, 2025
| @@ -1,3 +1,12 @@ | |||
|
|
|||
| # Enable matrix types extension tests for compilers supporting -fenable-matrix. | |||
There was a problem hiding this comment.
I think the comment doesn't match the code below?
| }; \ | ||
| auto InterleavedFn = [](std::function<void(int *)> II) -> unsigned { \ | ||
| Init II(Src); \ | ||
| _Pragma("clang loop vectorize(enable) interleave_count(4)") Loop \ |
There was a problem hiding this comment.
Looks like this PR cannot be merged until the pragma has handled correctly.
| /// * one where VF is picked automatically and interleaving is forced. | ||
| #define DEFINE_SCALAR_AND_VECTOR_EARLY_EXIT(Init, Src, Loop) \ | ||
| auto ScalarFn = [](std::function<void(int *)> II) -> unsigned { \ | ||
| Init II(Src); \ |
There was a problem hiding this comment.
This is pretty confusing as it looks like constructing a variable. Can you split this out over different lines so it's clearer, i.e.
InitSrc;
II(Src);
| // for to zero. | ||
| auto Init1 = [IdxToFind](int *Arr) { | ||
| std::fill_n(Arr, N, 1); | ||
| if (IdxToFind < N) |
There was a problem hiding this comment.
Is there a risk that a future compiler optimisation basically figures out the answer based on this init code (after inlining) and just optimises ScalarFn to return a constant before we even reach the loop vectoriser? It might be better to have Init1 and Init2 as real functions marked as noinline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial unit tests for early-exit vectorization covering a variation of auto-vectorization and forced interleaving with pragmas.
The interleaving variant is currently mis-compiled and needs
We should probably extend the tests to make sure we cover various other scenarios, including returning the loaded element for the early exit, different index types and array sizes.