Skip to content

Resolved 37820 console error in email preview #37933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: 2.4-develop
Choose a base branch
from
Open

Resolved 37820 console error in email preview #37933

wants to merge 7 commits into from

Conversation

Aditya-Prakash-Talluru
Copy link

@Aditya-Prakash-Talluru Aditya-Prakash-Talluru commented Aug 29, 2023 •
edited
Loading

Description (*)

Console error in Email preview in the Magento admin resolved the error

Related Pull Requests

#37820

Fixed Issues (if relevant)

  1. Fixes Console error in Email preview in the Magento admin #37820

Manual testing scenarios (*)

Login to backend (Admin)

Nav to Admin>Marketing>Email Templates>click preview
Open developer options and you can able to find a error in the console.

Screenshot 2023-08-29 at 3 13 08 PM

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 29, 2023

Hi @Aditya-Prakash-Talluru. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Aug 29, 2023
@Aditya-Prakash-Talluru
Copy link
Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label Jun 10, 2025
@engcom-Dash engcom-Dash moved this to Pending Review in Community Dashboard Jun 12, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

engcom-Hotel
engcom-Hotel requested changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Aditya-Prakash-Talluru,

Thanks for the contribution!

Please fix the failed static tests, other tests seems flaky to me.

Thanks

@engcom-Hotel engcom-Hotel moved this from Pending Review to Changes Requested in Community Dashboard Jun 27, 2025
@engcom-Dash engcom-Dash self-assigned this Jun 30, 2025
@engcom-Dash
Copy link
Contributor

engcom-Dash commented Jun 30, 2025 •
edited
Loading

Hello @Aditya-Prakash-Talluru I wanted to check if you are working on the static failures. If not, Can I take care of them? Just let me know what works best for you.

@engcom-Dash
Copy link
Contributor

Hello @Aditya-Prakash-Talluru I am taking care of the static failures. Thank you!

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Unit Tests

@engcom-Dash
Copy link
Contributor

@engcom-Hotel I have fixed the failing static test cases. I feel other failing test cases are not related to this PR hence moving this PR for review.

@engcom-Dash engcom-Dash moved this from Changes Requested to Pending Review in Community Dashboard Jul 1, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Pending Review to Review in Progress in Community Dashboard Jul 1, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Review in Progress to Ready for Testing in Community Dashboard Jul 2, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard Jul 3, 2025
@engcom-Bravo
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

Hi @Aditya-Prakash-Talluru,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Login to backend (Admin)
  • Nav to Admin>Marketing>Email Templates>click preview
  • Open developer options and you can able to find a error in the console.

Before: ✖️ 

Screenshot 2025-07-03 at 11 28 35 am

After: ✔️

Screenshot 2025-07-03 at 11 37 11 am

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Jul 3, 2025
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests B2B, Unit Tests

@engcom-Dash
Copy link
Contributor

The consistent Functional B2B Tests failure is known issue and Jira has been raised for the same. Other failures are inconsistent and flaky. They neither part of PR nor failing because of the PR changes.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37933/b1d214f89f1bfdcbcf2644d17f525932/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

image

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37933/de344afc3921608dd31c444a62bf52d4/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

image

Known Issue: StorefrontProductNoLongerVisibleInWishlistOnceUserUnassignedFromCompanyTest ACQE-8287

Hence moving this PR in Merge In Progress.

@engcom-Dash engcom-Dash moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

Assignees

@engcom-Dash engcom-Dash

Labels
Component: Email Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Console error in Email preview in the Magento admin
6 participants
@Aditya-Prakash-Talluru @engcom-Hotel @engcom-Dash @engcom-Bravo @mrtuvn @sinhaparul