Skip to content

Fix a few typos in PHPDoc comments #38809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fix a few typos in PHPDoc comments #38809

wants to merge 5 commits into from

Conversation

artttj
Copy link

@artttj artttj commented Jun 6, 2024 •
edited by m2-assistant bot
Loading

Description (*)

Fix a few typos in PHPDoc comments:

\Magento\ConfigurableProduct\Block\Product\View\Type::_getAdditionalConfig()
\Magento\ConfigurableProduct\Block\Adminhtml\Product\Composite\Fieldset\Configurable::_getAdditionalConfig()

Manual testing scenarios (*)

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix a few typos in PHPDoc comments #40042: Fix a few typos in PHPDoc comments

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Jun 6, 2024

Hi @artttj. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@artttj
Copy link
Author

artttj commented Jun 6, 2024

@magento run all tests

@artttj artttj changed the title Fix typo Fix a few typos in PHPDoc comments Jun 6, 2024
@artttj
Copy link
Author

artttj commented Jun 6, 2024

@magento run all tests

@engcom-Charlie engcom-Charlie added the Priority: P3 May be fixed according to the position in the backlog. label Jun 11, 2024
@artttj
Copy link
Author

artttj commented Aug 5, 2024

@magento run all tests

1 similar comment
@artttj
Copy link
Author

artttj commented Aug 30, 2024

@magento run all tests

@artttj artttj force-pushed the patch-1 branch 2 times, most recently from 8d5c046 to d6deb46 Compare October 1, 2024 16:25
@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label Jun 10, 2025
@engcom-Dash engcom-Dash moved this to Pending Review in Community Dashboard Jun 12, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel engcom-Hotel self-requested a review June 27, 2025 12:57
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Pending Review to Review in Progress in Community Dashboard Jun 27, 2025
engcom-Hotel
engcom-Hotel requested changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @artttj,

Thanks for the contribution!

As I can see in this PR, you have tried to fix some typos but we have some static test failures. We request you to fix those.

Other failures seems flaky to me.

Thanks

@engcom-Hotel engcom-Hotel moved this from Review in Progress to Changes Requested in Community Dashboard Jun 27, 2025
@engcom-Dash engcom-Dash self-assigned this Jun 30, 2025
@engcom-Dash
Copy link
Contributor

Hello @artttj

I wanted to check if you are working on the static failures. If not, Can I take care of them? Just let me know what works best for you.

@engcom-Dash
Copy link
Contributor

Hello @artttj I am taking care of the changes. Thank You!

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@engcom-Hotel I have fixed the static failures. Other failures are not related to this PR changes hence moving this PR for review.

@engcom-Dash engcom-Dash moved this from Changes Requested to Pending Review in Community Dashboard Jul 1, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Pending Review to Review in Progress in Community Dashboard Jul 1, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Review in Progress to Ready for Testing in Community Dashboard Jul 2, 2025
@artttj
Copy link
Author

artttj commented Jul 2, 2025

@engcom-Hotel I have fixed the static failures. Other failures are not related to this PR changes hence moving this PR for review.

Thanks for resolving, I appreciate it!

@engcom-Bravo engcom-Bravo self-assigned this Jul 4, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Ready for Testing to Testing in Progress in Community Dashboard Jul 4, 2025
@engcom-Bravo
Copy link
Contributor

Hi @artttj,

Thanks for the collaboration & contribution!

✔️ QA Passed

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Jul 4, 2025
@engcom-Bravo
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 4, 2025
Open
5 tasks
@engcom-Dash
Copy link
Contributor

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

Assignees

@engcom-Bravo engcom-Bravo

@engcom-Dash engcom-Dash

Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: testing in progress Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: Extended testing (optional)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Fix a few typos in PHPDoc comments
6 participants
@artttj @engcom-Hotel @engcom-Dash @engcom-Bravo @sinhaparul @engcom-Charlie