-
Notifications
You must be signed in to change notification settings - Fork 683
Open
Labels
Priority: P2Progress: doneSeverity: S3bugSomething isn't workingSomething isn't workinghelp wantedEligible for community contribution.Eligible for community contribution.
Description
Describe the bug
Leaving code comments in RootComponents/Category/category.js prevents webpack from running after a restart
To reproduce
Steps to reproduce the behavior:
0. Start watcher with yarn run watch:venia
- Go to packages/venia-ui/lib/RootComponents/Category/category.js
- comment out
if (totalPagesFromData === null) { return fullPageLoadingIndicator; }
with this//
comment style - Note that it seems to compile normally without errors
- Now restart the watcher
- It should give you an error like below
Expected behavior
Run's without a problem when you comment code
Additional context
It seem sto happen when the code has an if()
statement in the code that's been commented.
Now for the weirdest part: when you use multiline comments like /* */
the problem doesn't appear. So I think somewhere in the RootComponentsPlugin it somehow read's these comments
Please complete the following device information:
- Device [e.g. iPhone6, PC, Mac, Pixel3]:
- OS [e.g. iOS8.1, Windows 10]:
- Browser [e.g. Chrome, Safari]:
- Browser Version [e.g. 22]:
- Magento Version:
- PWA Studio Version:
- NPM version
npm -v
: - Node Version
node -v
:
Please let us know what packages this bug is in regards to:
-
venia-concept
-
venia-ui
-
pwa-buildpack
-
peregrine
-
pwa-devdocs
-
upward-js
-
upward-spec
-
create-pwa
0ctothorp
Metadata
Metadata
Assignees
Labels
Priority: P2Progress: doneSeverity: S3bugSomething isn't workingSomething isn't workinghelp wantedEligible for community contribution.Eligible for community contribution.