Skip to content

[bug]: RootComponents can't have // commented code in their files #2239

@Jordaneisenburger

Description

@Jordaneisenburger

Describe the bug
Leaving code comments in RootComponents/Category/category.js prevents webpack from running after a restart

To reproduce
Steps to reproduce the behavior:
0. Start watcher with yarn run watch:venia

  1. Go to packages/venia-ui/lib/RootComponents/Category/category.js
  2. comment out
    if (totalPagesFromData === null) { return fullPageLoadingIndicator; } with this // comment style
  3. Note that it seems to compile normally without errors
  4. Now restart the watcher
  5. It should give you an error like below

Screenshot 2020-03-11 at 11 36 45

6. Now go ahead and remove the piece of code that we've just commented. 7. Restart watcher and note it now work properly

Expected behavior
Run's without a problem when you comment code

Additional context
It seem sto happen when the code has an if() statement in the code that's been commented.
Now for the weirdest part: when you use multiline comments like /* */ the problem doesn't appear. So I think somewhere in the RootComponentsPlugin it somehow read's these comments

Please complete the following device information:

  • Device [e.g. iPhone6, PC, Mac, Pixel3]:
  • OS [e.g. iOS8.1, Windows 10]:
  • Browser [e.g. Chrome, Safari]:
  • Browser Version [e.g. 22]:
  • Magento Version:
  • PWA Studio Version:
  • NPM version npm -v:
  • Node Version node -v:

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions