Skip to content

PWA-3450 : Commit for initial package after conversion from TypeScrip… #4462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Jul 1, 2025

Conversation

del15881
Copy link
Collaborator

@del15881 del15881 commented May 8, 2025

…t to React

Description

This commit marks the Initial PWA LiveSearch Package, after conversion of the Referenced Repository (https://github.com/adobe/storefront-product-listing-page).

Currently It only has the feature to add Live Search Results to Category and Search Results Landing pages.

It currently is missing the Search Autocomplete AKA Search Popover feature.

The commit to work requires the Magento_LiveSearchGraphQlPwa module to be installed on Adobe Commerce Backend.
This module is currently available only for internal use.

Once installed the Live Search to be initialised on PLP and SRLP , it requires changes in local-intercept.js file of PWA Studio.

Example (local-intercept.js) :

`
const { Targetables } = require('@magento/pwa-buildpack');

function localIntercept(targets) {
const liveSearchTargetables = Targetables.using(targets);

//searchPage settings
const VeniaSearchPage = liveSearchTargetables.reactComponent(
    '@magento/venia-ui/lib/components/SearchPage/searchPage.js'
);

const LiveSearchPage = VeniaSearchPage.addImport(
    "import LiveSearchSRLPLoader from '@magento/venia-pwa-live-search/src/containers/LiveSearchSRLPLoader'"
);

VeniaSearchPage.insertBeforeJSX(
    'div className={classes.sidebar}',
    `<${LiveSearchPage} />`
);

VeniaSearchPage.removeJSX('div className={classes.sidebar}');
VeniaSearchPage.removeJSX('div className={classes.searchContent}');

//category page settings
const VeniaCategoryPage = liveSearchTargetables.reactComponent(
    '@magento/venia-ui/lib/RootComponents/Category/categoryContent.js'
);

const LiveCategoryContent = VeniaCategoryPage.addImport(
    "import LiveSearchPLPLoader from '@magento/venia-pwa-live-search/src/containers/LiveSearchPLPLoader'"
);

VeniaCategoryPage.insertBeforeJSX(
    '<Breadcrumbs categoryId={categoryId} />',
    `<${LiveCategoryContent} categoryId={categoryId} />`
);

VeniaCategoryPage.removeJSX('<Breadcrumbs categoryId={categoryId} />');
VeniaCategoryPage.removeJSX('<StoreTitle />');
VeniaCategoryPage.removeJSX('article className={classes.root}');

}

module.exports = localIntercept;

`

Related Issue

https://jira.corp.adobe.com/browse/PWA-3450

Closes #PWA-3450.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@del15881 del15881 requested a review from glo82145 May 8, 2025 13:25
@del15881 del15881 self-assigned this May 8, 2025
@del15881 del15881 added version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump. pkg:extensions labels May 8, 2025
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented May 8, 2025

Messages
📖

Associated JIRA tickets: PWA-3450.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 4a4552c

del15881 added 24 commits May 8, 2025 19:24
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jun 25, 2025

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 4a4552c

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jun 25, 2025

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • contains valid CMS Page data:
    • CypressError: `cy.visit()` failed trying to load:

      https://pr-4462.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false


    displays subcategories from the default root category:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4462.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false


    displays assigned products:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4462.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false

    ,contains valid CMS Page data specific to the different store:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4462.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false


    shows categories specific to the different store:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4462.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false


    shows products specific to the categories in the different store:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4462.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false

    ,lets users add products to cart regardless of store view:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4462.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 4a4552c

@glo80684
Copy link
Collaborator

Hey team,
I'm closing and reopening this PR #4462 so that it picks up the updated resources.
The current workflow is still tied to the old AMI, and reopening should help trigger a fresh build with the latest configuration.
Thanks!

@glo80684 glo80684 closed this Jun 26, 2025
@glo80684 glo80684 reopened this Jun 26, 2025
@glo82145
Copy link
Collaborator

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 30, 2025

Successfully started codebuild job for pr-test

@glo82145 glo82145 merged commit dded70d into develop Jul 1, 2025
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:extensions version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants