-
Notifications
You must be signed in to change notification settings - Fork 683
PWA-3450 : Commit for initial package after conversion from TypeScrip… #4462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
…arch Results Page
… returned no results' message instead.
LogERROR ON TASK: cypressTests
|
Hey team, |
…functionality is replaced by new file usePageTypeFromUrl.js
run pr-test |
Successfully started codebuild job for |
…t to React
Description
This commit marks the Initial PWA LiveSearch Package, after conversion of the Referenced Repository (https://github.com/adobe/storefront-product-listing-page).
Currently It only has the feature to add Live Search Results to Category and Search Results Landing pages.
It currently is missing the Search Autocomplete AKA Search Popover feature.
The commit to work requires the Magento_LiveSearchGraphQlPwa module to be installed on Adobe Commerce Backend.
This module is currently available only for internal use.
Once installed the Live Search to be initialised on PLP and SRLP , it requires changes in local-intercept.js file of PWA Studio.
Example (local-intercept.js) :
`
const { Targetables } = require('@magento/pwa-buildpack');
function localIntercept(targets) {
const liveSearchTargetables = Targetables.using(targets);
}
module.exports = localIntercept;
`
Related Issue
https://jira.corp.adobe.com/browse/PWA-3450
Closes #PWA-3450.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist