Skip to content

crypto: fix inclusion of OPENSSL_IS_BORINGSSL define #58845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codebytere
Copy link
Member

Refs #58387.

Fixes OPENSSL_IS_BORINGSSL not being defined in cases where it should be due to missing include. See relevant BoringSSL file

@codebytere codebytere requested review from jasnell and tniessen June 26, 2025 12:59
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 26, 2025
@codebytere
Copy link
Member Author

codebytere commented Jun 26, 2025

@jasnell looks like openssl itself doesn't have base.h - looks like to ensure it works I just need to include a file that normal OpenSSL does export, bc in BoringSSL they all include base.h. Do you have a preference?

See ex:

Screenshot 2025-06-26 at 3 17 36 PM

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (b4c5fb4) to head (c06590a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58845      +/-   ##
==========================================
+ Coverage   90.08%   90.09%   +0.01%     
==========================================
  Files         640      640              
  Lines      188446   188446              
  Branches    36960    36967       +7     
==========================================
+ Hits       169757   169776      +19     
+ Misses      11412    11395      -17     
+ Partials     7277     7275       -2     
Files with missing lines Coverage Δ
src/node_config.cc 96.55% <ø> (ø)

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell
Copy link
Member

jasnell commented Jun 27, 2025

No particular preference @codebytere ... I'd trust whatever you think needs to be done and whatever makes it work for you

@codebytere codebytere added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Jun 27, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2025
@nodejs-github-bot
Copy link
Collaborator

@@ -7,6 +7,10 @@
#include "node_options.h"
#include "util-inl.h"

#if HAVE_OPENSSL
#include "ncrypto.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include "ncrypto.h"
#include "ncrypto.h" // Ensure OPENSSL_IS_BORINGSSL is defined if applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants