-
-
Notifications
You must be signed in to change notification settings - Fork 32k
crypto: fix inclusion of OPENSSL_IS_BORINGSSL
define
#58845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
b20634e
to
c06590a
Compare
@jasnell looks like openssl itself doesn't have See ex: ![]() |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58845 +/- ##
==========================================
+ Coverage 90.08% 90.09% +0.01%
==========================================
Files 640 640
Lines 188446 188446
Branches 36960 36967 +7
==========================================
+ Hits 169757 169776 +19
+ Misses 11412 11395 -17
+ Partials 7277 7275 -2
🚀 New features to boost your workflow:
|
No particular preference @codebytere ... I'd trust whatever you think needs to be done and whatever makes it work for you |
@@ -7,6 +7,10 @@ | |||
#include "node_options.h" | |||
#include "util-inl.h" | |||
|
|||
#if HAVE_OPENSSL | |||
#include "ncrypto.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include "ncrypto.h" | |
#include "ncrypto.h" // Ensure OPENSSL_IS_BORINGSSL is defined if applicable |
Refs #58387.
Fixes
OPENSSL_IS_BORINGSSL
not being defined in cases where it should be due to missing include. See relevant BoringSSL file