🐛 do not include asName when creating digest of FROM name as asName

[AdamKorcz]

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

bug fix

• PR title follows the guidelines defined in our pull request documentation

What is the current behavior?

When calculating the digest in remediation, Scorecard would do that from python:3.7:build when the line was FROM python:3.7 as build. This would lead to issues such as #2906.

We are creating the digest on the following lines:

scorecard/remediation/remediations.go

Lines 105 to 113 in f96f4f4

	name, ok := dockerImageName(dep)
	if !ok {
	return nil
	}
	hash, err := digester.Digest(name)
	if err != nil {
	return nil
	}

From the PR, it should be clear that d.PinnedAt is assigned the wrong value; it gets assigned asPointer(asName) which is the root cause of the bug. digester.Digest(name) throws an error like: parsing reference "python:3.7:build": could not parse reference: python:3.7:build because of this.

What is the new behavior (if this is a feature change)?**

With this change, we create the digest from python:3.7 in the same line as above.

• Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #2906

Special notes for your reviewer

Does this PR introduce a user-facing change?

NONE

Ignore as-name with creating digest.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.30%. Comparing base (353ed60) to head (a554b83).
Report is 193 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4683      +/-   ##
==========================================
+ Coverage   66.80%   68.30%   +1.49%     
==========================================
  Files         230      249      +19     
  Lines       16602    18890    +2288     
==========================================
+ Hits        11091    12902    +1811     
- Misses       4808     5129     +321     
- Partials      703      859     +156     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

This pull request has been marked stale because it has been open for 10 days with no activity