🌱 add support for hadolint SAST #4688
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKorcz
requested review from
justaugustus and
spencerschrock
and removed request for
a team
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4688 +/- ##
==========================================
+ Coverage 66.80% 68.28% +1.47%
==========================================
Files 230 249 +19
Lines 16602 18890 +2288
==========================================
+ Hits 11091 12899 +1808
- Misses 4808 5131 +323
- Partials 703 860 +157 🚀 New features to boost your workflow:
|
Signed-off-by: Adam Korczynski <adam@adalogics.com>
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Comment on lines
45
to
+46
| "sonarqubecloud": true, | ||
| "hadolint-action": true, |
There was a problem hiding this comment.
this section is normally for github apps, is it an app or an action?
Comment on lines
382
to
383
| for _, tt := range tests { | ||
| searchRequest := clients.SearchRequest{ | ||
| Query: "github/codeql-action/analyze", | ||
| Path: "/.github/workflows", | ||
| } | ||
| t.Run(tt.name, func(t *testing.T) { |
There was a problem hiding this comment.
was there a driver behind redefining this in every test instead of once?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
feature
What is the current behavior?
Scorecard does not support hadolint SAST.
What is the new behavior (if this is a feature change)?**
Scorecard supports hadolint SAST.
Which issue(s) this PR fixes
Partially fixes #2318 (comment)
Special notes for your reviewer
Does this PR introduce a user-facing change?