Open
Description
Feature Type
Adding new functionality to pandas
Changing existing functionality in pandas
Removing existing functionality in pandas
Problem Description
test_sql.py must be run on a single thread now, because tests re-use the same table names. This can cause a race condition when different parametrizations of a test run on different threads
Feature Description
Add a uuid or something else to the table names in the test_sql.py module to disambiguate
Alternative Solutions
status quo
Additional Context
No response
Activity
UmbertoFasci commentedon Nov 20, 2024
take
[-]TST: Make test_sql.py serializable[/-][+]TST: Make test_sql.py parallelizable[/+]UmbertoFasci commentedon Nov 21, 2024
@WillAyd I am about halfway through the tests. I am generating a unique table uuid when indicated while maintaining the original context through the prefix.
Before:
After made parallelizable:
Let me know if you would like this done in a different fashion.
WillAyd commentedon Nov 21, 2024
Seems reasonable. Probably worth a helper function in the module to not have to repeat the same code in each function, but what you have looks like its headed in the right direction
arashgodgiven commentedon Dec 4, 2024
Hi, noticed this issue is being worked on. Is there any way I can assist or take on parts of the work to contribute? I'm interested in helping out.
UmbertoFasci commentedon Dec 4, 2024
Hi @arashgodgiven I am fairly close to wrapping this up. I am just handling the iris and types connectables now. Keep an eye out though, thanks for asking!
narutonamikaze commentedon Dec 18, 2024
hey ! i think the issue still hasn't been resolved, and would like to work upon it immediately !
UmbertoFasci commentedon Dec 18, 2024
All that is remaining is handling the test cases that share a database state through a couple of fixtures which is only a couple of connectable sets. Submitting PR this coming Friday.
UmbertoFasci commentedon Dec 20, 2024
@WillAyd I have gone ahead and submitted a PR for this issue, however I believe there is an issue with the current reviewer.
dougnovellano commentedon May 8, 2025
It looks like this PR was closed. Is this issue still being worked on, or being refined?
dShcherbakov1 commentedon May 20, 2025
@dougnovellano I'm interested in taking a look at this issue.
Is there anyone working on it now? I would be happy to start investigating this, or help collaborate if someone's already started and needs help tackling a specifically-scoped problem
Saberghanbarnejad commentedon May 23, 2025
Hi, I’m interested in helping make test_sql.py parallelizable by generating unique table names. Is this issue still open for contributions, considering PR #60595? Any guidance on next steps? Thanks!
dShcherbakov1 commentedon May 23, 2025
Hello @Saberghanbarnejad, I've set up a VM, and configured the necessary databases. This should provide a proper environment for running these integration tests. From here on out, it's just the Python code of, well, modifying the actual tests. Would you be interested in collaborating on this?
Saberghanbarnejad commentedon May 26, 2025
Hi @dShcherbakov1, thanks for setting up the VM and databases! I’m excited to collaborate on modifying the test_sql.py tests. Could you share more details on the changes needed?
Also, any pointers to relevant docs or examples would be great.
Thanks!
dShcherbakov1 commentedon May 26, 2025
Hello @Saberghanbarnejad, would you mind sending me an email at daniel.shcherbakov@gmail.com, email would probably be a better place to plan out technical details like that
I'm excited to collaborate on this!