-
Notifications
You must be signed in to change notification settings - Fork 6k
fix(runaway): ensure DistSQLContext's checker is synchronized with session variables (#61907) #62220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
fix(runaway): ensure DistSQLContext's checker is synchronized with session variables (#61907) #62220
Conversation
…ssion variables Signed-off-by: JmPotato <github@ipotato.me>
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JmPotato The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #62220 +/- ##
================================================
Coverage ? 36.9544%
================================================
Files ? 1676
Lines ? 613260
Branches ? 0
================================================
Hits ? 226627
Misses ? 364463
Partials ? 22170
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/test unit-test |
@lhy1024: No presubmit jobs available for pingcap/tidb@release-8.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #61907
What problem does this PR solve?
Issue Number: close #61899.
What changed and how does it work?
Update
GetDistSQLCtx
to check and align theRunawayChecker
in the cached DistSQL context with the session's current value.Check List
Tests
Prepare:
Before:
After:
Release note