Felix programs in-cluster no encapsulation routes #10472
Conversation
marvin-tigera
added
release-note-required
|
|
||
| // No encap routing tests. BrokenXSum is irrelevant in these cases. | ||
| {api.IPIPModeNever, "CalicoIPAM", false}, | ||
| {api.IPIPModeNever, "WorkloadIPs", false}, |
There was a problem hiding this comment.
These tests are moved from file fv/ipip_test.go and some adjustments are made for no-encap tests.
The above two cases, are basically running the same test cases for no-encap routing.
| return out | ||
| }, "10s", "100ms").Should(ContainSubstring("tx-checksumming: on")) | ||
| }) | ||
| } |
There was a problem hiding this comment.
This is one test that's not relevant to no encap routing. We don't configure any device.
| if BPFMode() { | ||
| if ipipMode == api.IPIPModeNever { | ||
| // one host routes per node | ||
| expectedNumRoutes = len(felixes) |
There was a problem hiding this comment.
The number of expected routes differs for no encap routing.
| if BPFMode() { | ||
| if ipipMode == api.IPIPModeNever { | ||
| // one host routes per node | ||
| expectedNumRoutes = (len(felixes) - 1) |
There was a problem hiding this comment.
Again, the number of expected routes differs for no encap.
| It("should configure the ipip device correctly", func() { | ||
| if ipipMode == api.IPIPModeNever { | ||
| Skip("ipip device is not available in no encap routing") | ||
| } |
There was a problem hiding this comment.
This test is no applicable to no encap since no device is managed.
| } | ||
| } | ||
| }) | ||
| } |
There was a problem hiding this comment.
This test is also not applicable to no encap since we don't add any SNAT rule. The SNAT rule is added here
Lines 958 to 972 in a9752ec
And it's not needed for no encap.
| It("should allow IPIP to external client if it is in ExternalNodesCIDRList", func() { | ||
| if ipipMode == api.IPIPModeNever { | ||
| Skip("external nodes is not applicable to no encap routing") | ||
| } |
There was a problem hiding this comment.
This test is about accepting tunnel traffic from external nodes:
We insert a rule to accept tunnel traffic from the allowed external nodes
here IPIP and VXLAN:
Line 249 in a9752ec
but it's not relevant to no encap.
mazdakn
changed the title
Description
Follow up on #10291
Adding a new manager to program no encapsulation routes.
Support for IPv6 is left out of this PR to make the review easier. It will be added in the next one.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.