[release-tool] fix normalizing pinned images components #10593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add tests
radTuti
added
docs-not-required
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the image normalization behavior in pinned image components by updating the logic to use the component name for registry lookup and adjusting the function comments accordingly. Additionally, new unit tests have been added to verify the normalization for various components.
- Updated normalizeComponent in pinnedversion.go to use the component name when looking up image mappings.
- Updated function documentation to reflect the new lookup behavior.
- Added comprehensive tests in pinnedversion_test.go for different component cases.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| release/internal/pinnedversion/pinnedversion.go | Updated the normalization logic for component images and adjusted documentation. |
| release/internal/pinnedversion/pinnedversion_test.go | Added tests to ensure that pinned images components are normalized correctly. |
radTuti
force-pushed
the
fix-master-images
branch
from
60e5663 to
446787b
Compare
coutinhop
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the normalization of images for a component to check in the registry image map using the component name.
Also added tests
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.