Update ubuntu packaging scripts #10615
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danudey
commented
Jun 27, 2025
danudey
commented
- Add checks for two required binaries
- Fix changelog being generated with incorrect distributions
* Add checks for two required binaries * Fix changelog being generated with incorrect distributions
danudey
added
docs-not-required
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Ubuntu packaging scripts by adding runtime checks for required tools and correcting the changelog generation to target the proper distribution.
- Added validation for
dchandpatchelfbinaries in the update script - Modified the
dchinvocation in the packaging script to include the correct distribution series
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| release/packaging/utils/make-packages.sh | Updated dch call to pass a --distribution flag for the series |
| release/packaging/utils/create-update-packages.sh | Added check_bin calls for dch and patchelf |
Comments suppressed due to low confidence (1)
release/packaging/utils/create-update-packages.sh:51
- [nitpick] Make error messages more actionable by suggesting an installation command, e.g.:
error_exit "Please install devscripts (e.g., sudo apt install devscripts)".
check_bin dch || error_exit "This script requires the 'dch' command from the 'devscripts' package."
| @@ -59,7 +59,7 @@ for package_type in "$@"; do | |||
| fi | |||
| rm -f debian/changelog debian/changelog.dch | |||
| dch --controlmaint --create --package "${PKG_NAME}" -v "${DEB_EPOCH}${debver}-$series" "${changelog_message}" | |||
| dch --controlmaint --release "" | |||
| dch --controlmaint --release --distribution $series "" | |||
There was a problem hiding this comment.
The --distribution flag should come after the empty release text and the $series variable should be quoted. For example:
dch --controlmaint --release "" --distribution "${series}"
Suggested change
| dch --controlmaint --release --distribution $series "" | |
| dch --controlmaint --release "" --distribution "${series}" |
Copilot uses AI. Check for mistakes.
nelljerram
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.