update manifest generation variables

[radTuti]

Description

This updates some variables for generating manifests to ensure they are only overriden explictly.

Related issues/PRs

Todos

• Tests
• Documentation
• Release note

Release Note

TBD

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

• docs-pr-required: This change requires a change to the documentation that has not been completed yet.
• docs-completed: This change has all necessary documentation completed.
• docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

• release-note-required: This PR has user-facing changes. Most PRs should have this label.
• release-note-not-required: This PR has no user-facing changes.

Other optional labels:

• cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
• needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

[Copilot]

Pull Request Overview

This PR updates environment variable names used for manifest generation to require explicit overrides and adds binary existence checks in the generation script.

• Renames CALICO_VERSION to PRODUCT_VERSION and introduces _OVERRIDE suffixes for operator image settings.
• Updates generate.sh to use the new override variables and validate presence of helm and yq.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
release/pkg/manager/calico/manager.go	Replace CALICO_VERSION with PRODUCT_VERSION and add OPERATOR_*_OVERRIDE vars
manifests/generate.sh	Use new override env vars and add checks for HELM and YQ binaries

Comments suppressed due to low confidence (3)

release/pkg/manager/calico/manager.go:913

• [nitpick] The new variable name PRODUCT_VERSION is less specific than the original CALICO_VERSION and inconsistent with the _OVERRIDE suffix used for operator settings. Consider renaming it to CALICO_VERSION_OVERRIDE for clarity and consistency.

	env = append(env, fmt.Sprintf("PRODUCT_VERSION=%s", r.calicoVersion))

manifests/generate.sh:24

• There are no tests covering the new override logic for PRODUCT_VERSION, OPERATOR_REGISTRY_OVERRIDE, and OPERATOR_IMAGE_OVERRIDE. Consider adding unit or integration tests to validate both default and override behaviors.

CALICO_VERSION=${PRODUCT_VERSION:-$defaultCalicoVersion}

manifests/generate.sh:22

• The script comments and README should be updated to document the new environment variables (PRODUCT_VERSION, OPERATOR_REGISTRY_OVERRIDE, OPERATOR_IMAGE_OVERRIDE) and their intended usage.

# Get versions to install.