[mypyc] Implement str.lower() and str.upper() primitive
#19375
+145
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jahongir-Qurbonov
changed the title
str.lower() and str.upper() primitive
for more information, see https://pre-commit.ci
JukkaL
reviewed
Jul 4, 2025
There was a problem hiding this comment.
Thanks for the PR! Left some comments -- the semantics are pretty tricky, and we need to be careful to catch all special cases. I'd suggest running a test (doesn't need to be included in this PR necessarily) comparing upper/lower of all length-1 strings with Python semantics.
| assert "abc".lower() == "abc" | ||
| assert "AbC123".lower() == "abc123" | ||
| assert "áÉÍ".lower() == "áéí" | ||
| assert "😴🚀".lower() == "😴🚀" |
There was a problem hiding this comment.
Also test special cases (verify that this agrees with normal Python semantics):
'SS'.lower() == 'ss''Σ'.lower()'İ'.lower()(changes length!)
| assert "ABC".upper() == "ABC" | ||
| assert "AbC123".upper() == "ABC123" | ||
| assert "áéí".upper() == "ÁÉÍ" | ||
| assert "😴🚀".upper() == "😴🚀" |
There was a problem hiding this comment.
Also test special case (verify that this agrees with normal Python semantics):
'ß'.upper() == 'SS''ffi'.upper()(length increases!)
… logic for non-ASCII characters
…fallback logic and using direct table lookups
…static lookup tables and using direct character conversion
…ing for character conversion
…e special characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add primitive for
str.lowerandstr.upper. Issue: mypyc/mypyc#1088