Skip to content

fix: fix file closing issue #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2025
Merged

fix: fix file closing issue #629

merged 3 commits into from
Jun 10, 2025

Conversation

WailGree
Copy link
Contributor

@WailGree WailGree commented Jun 10, 2025 •
edited by chenrui333
Loading

fixes #627
fixes #628

@Nick2bad4u
Copy link

thanks for fixing this.

@chenrui333
Copy link
Collaborator

Thanks for the fix! <3

@chenrui333 chenrui333 merged commit 07a2257 into softprops:master Jun 10, 2025
1 check passed
@chenrui333 chenrui333 changed the title Fix file closing issue fix: fix file closing issue Jun 10, 2025
@chenrui333 chenrui333 added the bug Something isn't working label Jun 10, 2025
@runningjustin
Copy link

runningjustin commented Jun 10, 2025 •
edited
Loading

@chenrui333 Still broken in 2.3.1

2025-06-10T21:43:49.9094173Z 
2025-06-10T21:43:49.9095636Z   #  /home/runner/actions-runner/externals/node20/bin/node[4109]: v8::MaybeLocal<v8::Promise> node::fs::FileHandle::ClosePromise() at ../src/node_file.cc:457
2025-06-10T21:43:49.9096504Z   #  Assertion failed: !closed_
2025-06-10T21:43:49.9096666Z 
2025-06-10T21:43:49.9096761Z ----- Native stack trace -----
2025-06-10T21:43:49.9096919Z 
2025-06-10T21:43:49.9099404Z  1: 0xcc7f77 node::Assert(node::AssertionInfo const&) [/home/runner/actions-runner/externals/node20/bin/node]
2025-06-10T21:43:49.9103423Z  2: 0xcd24fa node::fs::FileHandle::ClosePromise() [/home/runner/actions-runner/externals/node20/bin/node]
2025-06-10T21:43:49.9107847Z  3: 0xcd2666 node::fs::FileHandle::Close(v8::FunctionCallbackInfo<v8::Value> const&) [/home/runner/actions-runner/externals/node20/bin/node]
2025-06-10T21:43:49.9112591Z  4: 0xf6c56f v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) [/home/runner/actions-runner/externals/node20/bin/node]
2025-06-10T21:43:49.9117079Z  5: 0xf6cddd  [/home/runner/actions-runner/externals/node20/bin/node]
2025-06-10T21:43:49.9122034Z  6: 0xf6d2a5 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/home/runner/actions-runner/externals/node20/bin/node]
2025-06-10T21:43:49.9128686Z  7: 0x1977df6  [/home/runner/actions-runner/externals/node20/bin/node]
2025-06-10T21:43:49.9128965Z 
2025-06-10T21:43:49.9129068Z ----- JavaScript stack trace -----
2025-06-10T21:43:49.9129272Z 
2025-06-10T21:43:49.9129446Z 1: close (node:internal/fs/promises:250:23)
2025-06-10T21:43:49.9130014Z 2: upload (/home/runner/work/_actions/softprops/action-gh-release/v2.3.1/dist/index.js:16:16285)

@walsha2
Copy link

walsha2 commented Jun 10, 2025

Still broken in 2.3.1

#630

chenrui333 added a commit that referenced this pull request Jun 10, 2025
@chenrui333
Revert "fix: fix file closing issue (#629)"
eaae3e7 
This reverts commit 07a2257.
@chenrui333 chenrui333 mentioned this pull request Jun 10, 2025
Merged
chenrui333 added a commit that referenced this pull request Jun 10, 2025
@chenrui333
fix: revert fs:readableWebStream change (#632)
552dc55 
* Revert "fix: fix file closing issue (#629)"

This reverts commit 07a2257.

* fix: revert `fh.readableWebStream` change

Signed-off-by: Rui Chen <rui@chenrui.dev>

---------

Signed-off-by: Rui Chen <rui@chenrui.dev>
@Nick2bad4u
Copy link

Fixed again?

@chenrui333
Copy link
Collaborator

chenrui333 commented Jun 11, 2025 •
edited
Loading

@Nick2bad4u does 2.3.2 release work for you? (if not, feel free to create a new issue)

@Nick2bad4u
Copy link

@Nick2bad4u does 2.3.2 release work for you? (if not, feel free to create a new issue)

It works. My mistake. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to run softprops/action-gh-release v2.3.0 failed
5 participants
@WailGree @Nick2bad4u @chenrui333 @runningjustin @walsha2