Allow custom FeedGeneratorService implementations #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows package consumers to implement their own feed generators.
Key changes
FeedGenerators
Collection Builder and associated factory to allow consumers to specify additional generators in startup configuration.Id
,DisplayName
, andFormat
properties toIProductFeedGeneratorService
in the same implementation style as Property ExtractorsProductFeedController
updated to generate the correct feed type.For consideration
FeedGeneratorId
property of FeedSettings to the original database columnFeedType
. This should mean that existing GoogleMerchantFeeds will continue to work without changes but makes things a bit inconsistant, so perhaps a Migration here would be better?