wip: root params in route handlers #80684
Draft
+119
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
created-by: Next.js team
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
lubieowoce
changed the base branch from
lubieowoce/rootparams-module
to
graphite-base/80684
lubieowoce
force-pushed
the
lubieowoce/root-params-in-route-handlers
branch
from
f70791b to
23b8248
Compare
lubieowoce
changed the base branch from
graphite-base/80684
to
lubieowoce/root-params-types
CodSpeed Performance ReportMerging #80684 will not alter performanceComparing Summary
|
lubieowoce
force-pushed
the
lubieowoce/root-params-in-route-handlers
branch
from
23b8248 to
87f9b63
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-types
branch
from
41da255 to
1674139
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-in-route-handlers
branch
from
87f9b63 to
bf41c6b
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-types
branch
from
1674139 to
b129141
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-in-route-handlers
branch
from
bf41c6b to
f692cde
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-types
branch
2 times, most recently
from
68666ef to
8a43e92
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-in-route-handlers
branch
from
f692cde to
bf12851
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-types
branch
from
8a43e92 to
34ecb17
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-in-route-handlers
branch
2 times, most recently
from
7fc10cb to
6248ef5
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-types
branch
from
34ecb17 to
7b579f8
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-in-route-handlers
branch
from
6248ef5 to
32e74d6
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-types
branch
2 times, most recently
from
752d7e6 to
6cf65cb
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-in-route-handlers
branch
from
32e74d6 to
2a607fc
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-in-route-handlers
branch
from
2a607fc to
b4fe9d1
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-types
branch
from
6cf65cb to
6b6d73a
Compare
lubieowoce
commented
Jul 9, 2025
| @@ -274,6 +274,7 @@ export async function adapter( | |||
| const requestStore = createRequestStoreForAPI( | |||
| request, | |||
| request.nextUrl, | |||
| {}, // TODO(root-params): compute and pass real rootParams | |||
lubieowoce
force-pushed
the
lubieowoce/root-params-in-route-handlers
branch
from
519d35e to
17ac63c
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-types
branch
from
6b6d73a to
11ede39
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-in-route-handlers
branch
from
17ac63c to
bfe1fe3
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-types
branch
from
11ede39 to
80bdbc2
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-in-route-handlers
branch
from
bfe1fe3 to
d93fb49
Compare
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
.../app-dir/app-root-params-getters/fixtures/simple/app/[lang]/[locale]/route-handler/route.tsx
Show resolved
Hide resolved
lubieowoce
force-pushed
the
lubieowoce/root-params-types
branch
from
80bdbc2 to
639d677
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-in-route-handlers
branch
2 times, most recently
from
ae507a7 to
e9ce96d
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-types
branch
2 times, most recently
from
cb48272 to
e67bd13
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-in-route-handlers
branch
from
e9ce96d to
2caaeca
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-types
branch
from
e67bd13 to
c220c1f
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-in-route-handlers
branch
from
2caaeca to
540330c
Compare
This PR enables the use of root params in route handlers by:
1. Modifying the app route module to extract root params from
context.params based on rootParamNames
2. Passing these root params to the request store in route handlers
3. Removing the error that previously prevented using root params in
route handlers
4. Simplifying the rootParams handling by directly using string arrays
instead of ParamInfo objects
5. Replacing the custom encodeToBase64 utility with standard
Buffer.from().toString('base64')
lubieowoce
force-pushed
the
lubieowoce/root-params-in-route-handlers
branch
from
540330c to
85295bd
Compare
lubieowoce
force-pushed
the
lubieowoce/root-params-types
branch
from
c220c1f to
b0cdc2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.