solid app is larger in rolldown-vite than old vite

[huseeiin]

Describe the bug

vite rollup: 6.67 kb
rolldown-vite: 11.78 kb

Reproduction

https://stackblitz.com/edit/vitejs-rolldown-vite-dvdyvsqx?file=package.json

Steps to reproduce

No response

System Info

do i need this if the reproduction is on stackblitz?

Used Package Manager

pnpm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs and the Rolldown-related guide.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[sapphi-red]

By checking the diff of the output, I think these are the missing optimizations:

• minifier: remove unused variable declaration oxc-project/oxc#10033
• minifier: eliminate dead code that depends on constant variable oxc-project/oxc#10843
• minifier: eliminate unused properties of readonly objects oxc-project/oxc#10844
• minifier: inline literal property values of readonly objects oxc-project/oxc#10845

[oliverjam]

Yeah seeing the same thing testing on a basic React SPA. Building with just vite produces a 1,960kb bundle, but rolldown-vite is 2,749kb. That's a big difference! (it's a private repo so I can't share a repro, sorry)

[huseeiin]

Yeah seeing the same thing testing on a basic React SPA. Building with just vite produces a 1,960kb bundle, but rolldown-vite is 2,749kb. That's a big difference! (it's a private repo so I can't share a repro, sorry)

NODE_ENV=production vite build may help for react apps. i don't know tho

[kevinmarrec]

Experiencing same issue in a quite standard Vue.js app.

Rolldown-Vite seems to ship "more" from treeshaking Vue.js runtime, shipping extra 5kb.

Also having my css 2x bigger using UnoCSS, the difference being Rolldown-Vite outputting :

.foo {
  color: red;
}

.bar {
  color: red;
}

Instead of (using Vite):

.foo, .bar {
  color: red;
}

But maybe UnoCss Vite plugin isn't fully compatible with Rolldown somehow

[sapphi-red]

There are multiple potential causes of a larger output (e.g. missing optimization in rolldown/oxc, unsafe assumption in rollup). If you make a repro, I can figure out the cause.

[sapphi-red]

Yeah seeing the same thing testing on a basic React SPA. Building with just vite produces a 1,960kb bundle, but rolldown-vite is 2,749kb. That's a big difference! (it's a private repo so I can't share a repro, sorry)

NODE_ENV=production vite build may help for react apps. i don't know tho

Vite sets NODE_ENV=production by default, so that probably won't change the output.

[sapphi-red]

Linking #196 (comment) as that list also contains some issues that may related to others.

[shulaoda]

@hyf0 cc