`@cloudflare/vite-plugin` without node compat breaks due to `"node:module" imported from "rolldown:runtime"`

[hi-ogawa]

Describe the bug

The reproduction with @cloudflare/vite-plugin is found in https://github.com/hi-ogawa/reproductions/tree/main/rolldown-runtime-external-side-effect-cf. I briefly checked the plugin and made a minimal repro in https://github.com/hi-ogawa/reproductions/tree/main/rolldown-runtime-external-side-effect

    // mini version of
    // https://github.com/cloudflare/workers-sdk/blob/f45208ca588d0565fa4e3abcee7be3974a1ef85d/packages/vite-plugin-cloudflare/src/index.ts#L799
    {
      name: 'repro',
      enforce: 'pre',
      resolveId(source, importer, options) {
        if (source === 'node:module') {
          console.log("[resolveId]", { source, importer });
          return {
            id: source,
            external: true,
          };
        }
      },
    }

@cloudflare/vite-plugin uses resolveId to track unsupported node builtin import and shows a warning. This logic is also applied to rolldown:runtime on rolldown-vite and thus causing an warning and also runtime error due to import "node:module" being left in the server build.

I'm raising an issue here as I wasn't sure if this is something that should be addressed on rolldown/vite or plugin side. If we suggest cloudflare plugin side to add rolldown specific logic, then, for example build.rollOptions.platform: "neutral" avoids node:module from rolldown runtime and that seems to work on my use case (hi-ogawa/vite-plugins#931)

  environments: {
    ssr: {
      build: {
        rollupOptions: {
          platform: "neutral",
        }
      }
    }
  }

Reproduction

https://github.com/hi-ogawa/reproductions/tree/main/rolldown-runtime-external-side-effect-cf
https://github.com/hi-ogawa/reproductions/tree/main/rolldown-runtime-external-side-effect

Steps to reproduce

See READE.md in repro

System Info

System:
    OS: Linux 6.14 Arch Linux
    CPU: (16) x64 12th Gen Intel(R) Core(TM) i7-12650H
    Memory: 18.32 GB / 31.05 GB
    Container: Yes
    Shell: 5.2.37 - /usr/bin/bash
  Binaries:
    Node: 22.14.0 - ~/.volta/tools/image/node/22.14.0/bin/node
    npm: 10.9.2 - ~/.volta/tools/image/node/22.14.0/bin/npm
    pnpm: 10.11.1 - ~/.volta/tools/image/node/22.14.0/bin/pnpm
    bun: 1.2.4 - ~/.local/bin/bun
  Browsers:
    Brave Browser: 137.1.79.119
    Chromium: 136.0.7103.113
  npmPackages:
    rolldown-vite:  6.3.18

Used Package Manager

pnpm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs and the Rolldown-related guide.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[sapphi-red]

I think platform: 'node' expects the runtime to be (fully) compatible with Node.

I think we can suggest both, as those will align with some other settings.

1. Vite sets moduleSideEffects: false for builtin modules. https://github.com/vitejs/vite/blob/feb3a11454d27706f39912a934cee8666f92a884/packages/vite/src/node/plugins/resolve.ts#L413
2. @cloudflare/vite-plugin sets platform: 'neutral' for the optimizer. https://github.com/cloudflare/workers-sdk/blob/91e5f7fd589c1a9e7c249d13dc5e497bebff5ac2/packages/vite-plugin-cloudflare/src/cloudflare-environment.ts#L173

[hi-ogawa]

Sounds good to me 👍 I'll raise "support rolldown-vite" issue on workers-sdk repo and reference this issue to start with. Probably I can submit moduleSideEffects fix right away, but not sure how they want to handle rolldown-vite specific options like rollupOptions.platform.