Skip to content

advancedChunks/strictExecutionOrder breaks React Router app runtime #251

@pawelblaszczyk5

Description

@pawelblaszczyk5

Describe the bug

Hi 👋

Report this re thread on Discord: https://discord.com/channels/1171783886200643635/1382015960625582133

Enabling strictExecutionOrder and/or advancedChunks breaks React Router app at runtime. Stuff that normally is defined turns out to be undefined. At my job project, I can reproduce it also in client build where routes components which has side-effects (RR wrap them with HOC) are undefined. I couldn't replicate this in smaller project but I spotted that this also happens in server build even with bare template.

Build passes successfully but then I'm running into this:

TypeError: Cannot read properties of undefined (reading 'routes')

(full logs below). It seems like one of init functions isn't invoked at all:

Image

Similar thing happens at my job project where RR warns me that Route component isn't defined - adding log before exports I can observe them being still not initialized.

Reproduction

https://github.com/pawelblaszczyk5/rolldown-vite-strict-ordering

Steps to reproduce

  1. Create React Router project - e.g. pnpm create react-router@latest
  2. Enable either advancedChunks and/or strictExecutionOrder (this can be either enabled globally or per environment if environment enabled in RR config)
  3. Run build - e.g. pnpm run build
  4. Start app - e.g. pnpm run start
  5. Visit server and observe error in logs

System Info

System:
    OS: macOS 15.5
    CPU: (8) arm64 Apple M1 Pro
    Memory: 294.42 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 24.1.0 - ~/.local/state/fnm_multishells/1679_1749638326206/bin/node
    npm: 11.3.0 - ~/.local/state/fnm_multishells/1679_1749638326206/bin/npm
    pnpm: 10.12.1 - ~/.local/state/fnm_multishells/1679_1749638326206/bin/pnpm
    bun: 1.1.33 - ~/.bun/bin/bun
  Browsers:
    Chrome: 137.0.7151.69
    Edge: 120.0.2210.121
    Safari: 18.5
  npmPackages:
    rolldown-vite:  6.3.18

Used Package Manager

pnpm

Logs

I'm not sure how to run debug build using RR but I provided reproduction. Also here is the log of server erroring:

Click to expand!
pawelblaszczyk@MacBookPro rolldown-vite-strict-ordering % pnpm start

> rolldown-vite-strict-ordering@ start /Users/pawelblaszczyk/dev/rolldown-vite-strict-ordering
> react-router-serve ./build/server/index.js

[react-router-serve] http://localhost:3000 (http://192.168.1.47:3000)
TypeError: Cannot read properties of undefined (reading 'routes')
    at ServerRouter (file:///Users/pawelblaszczyk/dev/rolldown-vite-strict-ordering/node_modules/.pnpm/react-router@7.6.2_react-dom@19.1.0_react@19.1.0__react@19.1.0/node_modules/react-router/dist/development/chunk-NL6KNZEE.mjs:9811:14)
    at renderWithHooks (/Users/pawelblaszczyk/dev/rolldown-vite-strict-ordering/node_modules/.pnpm/react-dom@19.1.0_react@19.1.0/node_modules/react-dom/cjs/react-dom-server.node.production.js:4179:18)
    at renderElement (/Users/pawelblaszczyk/dev/rolldown-vite-strict-ordering/node_modules/.pnpm/react-dom@19.1.0_react@19.1.0/node_modules/react-dom/cjs/react-dom-server.node.production.js:4317:14)
    at retryNode (/Users/pawelblaszczyk/dev/rolldown-vite-strict-ordering/node_modules/.pnpm/react-dom@19.1.0_react@19.1.0/node_modules/react-dom/cjs/react-dom-server.node.production.js:4919:16)
    at performWork (/Users/pawelblaszczyk/dev/rolldown-vite-strict-ordering/node_modules/.pnpm/react-dom@19.1.0_react@19.1.0/node_modules/react-dom/cjs/react-dom-server.node.production.js:5561:13)
    at AsyncLocalStorage.run (node:internal/async_local_storage/async_context_frame:63:14)
    at /Users/pawelblaszczyk/dev/rolldown-vite-strict-ordering/node_modules/.pnpm/react-dom@19.1.0_react@19.1.0/node_modules/react-dom/cjs/react-dom-server.node.production.js:6153:27
    at node:internal/process/task_queues:151:7
    at AsyncResource.runInAsyncScope (node:async_hooks:214:14)
    at AsyncResource.runMicrotask (node:internal/process/task_queues:148:8)
TypeError: Cannot read properties of undefined (reading 'routes')
    at ServerRouter (file:///Users/pawelblaszczyk/dev/rolldown-vite-strict-ordering/node_modules/.pnpm/react-router@7.6.2_react-dom@19.1.0_react@19.1.0__react@19.1.0/node_modules/react-router/dist/development/chunk-NL6KNZEE.mjs:9811:14)
    at renderWithHooks (/Users/pawelblaszczyk/dev/rolldown-vite-strict-ordering/node_modules/.pnpm/react-dom@19.1.0_react@19.1.0/node_modules/react-dom/cjs/react-dom-server.node.production.js:4179:18)
    at renderElement (/Users/pawelblaszczyk/dev/rolldown-vite-strict-ordering/node_modules/.pnpm/react-dom@19.1.0_react@19.1.0/node_modules/react-dom/cjs/react-dom-server.node.production.js:4317:14)
    at retryNode (/Users/pawelblaszczyk/dev/rolldown-vite-strict-ordering/node_modules/.pnpm/react-dom@19.1.0_react@19.1.0/node_modules/react-dom/cjs/react-dom-server.node.production.js:4919:16)
    at performWork (/Users/pawelblaszczyk/dev/rolldown-vite-strict-ordering/node_modules/.pnpm/react-dom@19.1.0_react@19.1.0/node_modules/react-dom/cjs/react-dom-server.node.production.js:5561:13)
    at AsyncLocalStorage.run (node:internal/async_local_storage/async_context_frame:63:14)
    at /Users/pawelblaszczyk/dev/rolldown-vite-strict-ordering/node_modules/.pnpm/react-dom@19.1.0_react@19.1.0/node_modules/react-dom/cjs/react-dom-server.node.production.js:6153:27
    at node:internal/process/task_queues:151:7
    at AsyncResource.runInAsyncScope (node:async_hooks:214:14)
    at AsyncResource.runMicrotask (node:internal/process/task_queues:148:8)
GET / 500 - - 25.786 ms

Validations

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug: upstreamBug in a dependency of Vite

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions