fix: importing an optional peer dep should throw an runtime error #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
sapphi-red
force-pushed
the
fix/import-optional-peer-dep-should-throw-an-error
branch
from
ab5dc4e to
2fdd982
Compare
sapphi-red
force-pushed
the
fix/import-optional-peer-dep-should-throw-an-error
branch
from
2fdd982 to
edfd293
Compare
github-merge-queue bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Jun 17, 2025
… an runtime error (#4980) Port of vitejs/vite#20029 and vitejs/rolldown-vite#167.
sapphi-red
force-pushed
the
fix/import-optional-peer-dep-should-throw-an-error
branch
from
edfd293 to
6a488f3
Compare
sapphi-red
force-pushed
the
rolldown-vite
branch
from
70203f7 to
6f8287b
Compare
sapphi-red
force-pushed
the
fix/import-optional-peer-dep-should-throw-an-error
branch
from
6a488f3 to
268d892
Compare
|
Native plugins test passed locally with rolldown/rolldown#4995 |
sapphi-red
deleted the
fix/import-optional-peer-dep-should-throw-an-error
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See vitejs#20029
The native plugins test fails are expected as this PR only changes the JS plugins.
fixes #165