Skip to content

feat: update rolldown and support resolveSubpathImports for oxcResolvePlugin #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

feat: update rolldown and support resolveSubpathImports for oxcResolvePlugin #287

merged 2 commits into from
Jul 2, 2025
+72 −101

Conversation

shulaoda
Copy link
Member

Description

Wait for rolldown/rolldown#5093

@shulaoda shulaoda requested a review from sapphi-red June 28, 2025 00:45
@shulaoda shulaoda marked this pull request as draft June 28, 2025 00:45
@shulaoda shulaoda force-pushed the 06-28-feat_native-plugin_support_resolvesubpathimports_for_oxcresolveplugin branch from dfae076 to 602a466 Compare June 30, 2025 05:42
@shulaoda shulaoda marked this pull request as ready for review June 30, 2025 05:42
@shulaoda shulaoda marked this pull request as draft June 30, 2025 05:45
@shulaoda shulaoda marked this pull request as ready for review June 30, 2025 05:49
sapphi-red
sapphi-red requested changes Jun 30, 2025
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the tests are failing

@shulaoda
Copy link
Member Author

shulaoda commented Jun 30, 2025 •
edited
Loading

It seems the tests are failing

Using #[napi(js_name = "'vite:import-glob'")] fails to correctly deserialize { 'vite:import-glob': { isSubImportsPattern: true } }. I need to investigate how napi handles such cases. @Brooooooklyn cc
https://github.com/rolldown/rolldown/blob/eaf931cd179436811a02245cf03e4d68914afe34/crates/rolldown_binding/src/options/plugin/types/binding_vite_plugin_custom.rs#L7-L13

@shulaoda
Copy link
Member Author

Ref napi-rs/napi-rs#2752

@shulaoda shulaoda mentioned this pull request Jun 30, 2025
Merged
github-merge-queue bot pushed a commit to rolldown/rolldown that referenced this pull request Jun 30, 2025
@shulaoda
chore(deps): update NAPI-RS to 3.0.0-beta.11 (#5110)
2fcf1af 
Related to vitejs/rolldown-vite#287
@shulaoda shulaoda force-pushed the 06-28-feat_native-plugin_support_resolvesubpathimports_for_oxcresolveplugin branch from 602a466 to f41d669 Compare July 1, 2025 08:27
@shulaoda shulaoda requested a review from sapphi-red July 1, 2025 08:28
@sapphi-red sapphi-red changed the title feat(native-plugin): support resolveSubpathImports for oxcResolvePlugin feat: update rolldown and support resolveSubpathImports for oxcResolvePlugin Jul 2, 2025
@sapphi-red sapphi-red merged commit 5c0dddb into rolldown-vite Jul 2, 2025
17 checks passed
@sapphi-red sapphi-red deleted the 06-28-feat_native-plugin_support_resolvesubpathimports_for_oxcresolveplugin branch July 2, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shulaoda @sapphi-red