Skip to content

chore: move all pnpm settings to pnpm-workspace.yaml #19895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

btea
Copy link
Collaborator

@btea btea commented Apr 18, 2025

Description

To ease management and avoid conflicts with npm, pnpm supports moving all configurations to the pnpm-workspace.yaml file. For more https://github.com/orgs/pnpm/discussions/9037

@btea btea marked this pull request as draft April 18, 2025 14:05
@btea btea marked this pull request as ready for review April 18, 2025 14:48
@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Apr 21, 2025
sapphi-red
sapphi-red previously approved these changes Apr 21, 2025
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this shouldn't cause any problems.
Some behaviors I found by testing:

  • pnpm.overrides field in package.json has higher priority over overrides field in pnpm-workspace.yaml
  • pnpm.overrides field in package.json and overrides field in pnpm-workspace.yaml are not merged

patak-dev
patak-dev previously approved these changes Apr 22, 2025
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving this open for a bit in case others also want to check it out

@btea btea dismissed stale reviews from patak-dev and sapphi-red via 8fbfd15 June 24, 2025 07:45
@sapphi-red sapphi-red changed the title refactor: move all pnpm settings to pnpm-workspace.yaml chore: move all pnpm settings to pnpm-workspace.yaml Jun 25, 2025
@sapphi-red sapphi-red merged commit 8c9840f into vitejs:main Jun 25, 2025
17 checks passed
@btea btea deleted the refactor/move-pnpm-setting-to-pnpm-workspace branch June 25, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants