feat(types): use terser types from terser package #20274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
p2-nice-to-have
commit: |
commit: |
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
✅ astro, analogjs, laravel, qwik, marko, rakkas, one, unocss, quasar, ladle, nuxt, storybook, sveltekit, vite-plugin-svelte, vite-plugin-pwa, vite-plugin-react, vite-environment-examples, vitest, vitepress, vuepress, vite-plugin-cloudflare, vite-rsc, vite-plugin-vue, vite-setup-catalogue |
bluwy
approved these changes
Jun 23, 2025
Comment on lines
+10
to
+11
| export type TerserMinifyOptions = Terser.MinifyOptions | ||
| export type TerserMinifyOutput = Terser.MinifyOutput |
There was a problem hiding this comment.
Is there a reason to re-export the type instead of other modules importing Terser directly?
There was a problem hiding this comment.
It is to avoid Terser to be renamed to Terser$1 in the output dts.
patak-dev
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the inlined types for terser and made it use the types from terser package when installed.
This would:
The only downside of this is that users that doesn't use terser but sets terser options and wants to have a stricter type needs to install terser now.