Skip to content

test(resolve): add glob pattern sideEffects field test #20302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sapphi-red
Copy link
Member

Description

Add a test that covers vitejs#283.
It passes here, but was failing with native resolver plugin in rolldown-vite.

@sapphi-red sapphi-red marked this pull request as ready for review June 26, 2025 10:38
@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test labels Jun 26, 2025
@patak-dev patak-dev merged commit 232cfa4 into vitejs:main Jun 26, 2025
18 checks passed
@sapphi-red sapphi-red deleted the test/resolve-glob-side-effects-field branch June 27, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants