-
Notifications
You must be signed in to change notification settings - Fork 10
Enhanced mobile tabContainer
+ navigator
routing support
#3984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
/** | ||
* Base route name for this navigator, with the route for each page being "[route]/[page.id]". | ||
*/ | ||
route?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matching the config from tabContainerModel
- allow dev to scope down routing responsiveness to a particular sub-path.
Goal here is to allow use of TabContainer and Navigator within nested sub-routes. Specifically looking to support an overall UI pattern where we have a top-level tab container, switchable primarily via a bottom tab-bar, and within each top-level tab we have a swipable, navigator-powered page stack. Possible TODOs:
|
NOTE - had a good discussion with @ghsolomon and @oodarluz today and we are going to look to double-down on See #3985 - evolving spec to capture the plan. Leaving this PR open in draft for the moment, but expect to close out this branch without merging in the near future. |
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
develop
branch as of last change.breaking-change
label + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.