Do not use root logger #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures are not caused by changes in this PR, but because Python versions are too old. I suggest to bump the supported Python versions to 3.10–3.13 (but this should probably be done in a separate PR). |
|
Sorry - completely missed this PR somehow. Will look into it. |
|
I've removed the old python versions - you can pull the changes and then the tests should run |
|
I've rebased, once you approve the workflow we'll know! |
|
thanks! looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package uses the root logger, which makes it hard to customize the logging behavior. Therefore, I suggest to use a package-level logger as implemented in this PR.